Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type for some chars between 0x600 and 0x6ff #7844

Closed
wants to merge 1 commit into from

Conversation

adrianheine
Copy link

No description provided.

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 23, 2016

The specification for this is here: ftp://ftp.unicode.org/Public/UNIDATA/UnicodeData.txt

@adrianheine It appears that the beginning of the block also contains incorrect types when comparing our code to the specification above. For example, the first six items should be "AN", but we have "AL". Do you know if the other entries should be adjusted as well?

@adrianheine
Copy link
Author

I don't know much about this. Since the first items are combining marks, I suppose their directionality doesn't matter too much?

@adrianheine
Copy link
Author

I updated my commit to fix all 0600–06ff items, but feel free to favor your commit since it fixes all of them.

@timvandermeij
Copy link
Contributor

Closing as fixed in #7846. Thank you for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants